Trigger workflow when PR is marked ready for review#1753
Merged
janfb merged 1 commit intosbi-dev:mainfrom Feb 5, 2026
Merged
Conversation
Previously, the CI workflow utilized the default pull_request trigger, which does not listen for the ready_for_review event. This caused the CI to remain idle when a Draft PR was promoted to Ready, requiring manual empty commits to trigger the tests. This change explicitly defines the pull request types to include ready_for_review, ensuring the CI pipeline runs automatically when a PR status changes from Draft to Ready.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1753 +/- ##
=======================================
Coverage 88.54% 88.54%
=======================================
Files 137 137
Lines 11515 11515
=======================================
Hits 10196 10196
Misses 1319 1319
Flags with carried forward coverage won't be shown. Click here to find out more. |
janfb
approved these changes
Feb 5, 2026
Contributor
janfb
left a comment
There was a problem hiding this comment.
absolute agree, this makes a lot of sense, thanks @satwiksps 🙌
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This is a suggestion based on my personal experience to smooth out the contribution workflow. If this limitation is intentional (e.g., to save runner resources) or preferred by the maintainers, I am completely fine with rejecting the PR without merging
This PR updates the Continuous Integration (CI) workflow to automatically trigger when a Pull Request is converted from "Draft" to "Ready for Review"
Currently, the
ci.ymlworkflow is configured to skip runs on Draft PRs which is fine. However, because the defaultpull_requesttrigger only listens foropened,synchronize, andreopenedevents, the CI pipeline ignores theready_for_revieweventSo when a contributor marks a Draft PR as "Ready for Review," the CI does not run. Contributors are forced to push an empty commit (e.g.,
git commit --allow-empty) just to trigger the tests. This PR removes that friction to improve DXChanges
.github/workflows/ci.ymlto explicitly definepull_requesttrigger typesready_for_reviewto the list of types, ensuring the workflow captures the transition from Draft to Ready