Skip to content

[FIX] webui-templates: update time-elements library - #151

Merged
sbidoul merged 1 commit into
sbidoul:mainfrom
Corentvn:fix/migrate-time-ago-to-relative-time
May 26, 2026
Merged

[FIX] webui-templates: update time-elements library#151
sbidoul merged 1 commit into
sbidoul:mainfrom
Corentvn:fix/migrate-time-ago-to-relative-time

Conversation

@Corentvn

@Corentvn Corentvn commented May 13, 2026

Copy link
Copy Markdown
Contributor

The @github/time-element library is now deprecated. Its authors recommend using @github/relative-time-element instead.

This commit was motivated by the fact that Runboat uses the <time-ago> and time-elements@latest library, which currently points to version 4.0.0.
In this release, the <time-ago> component was removed in favor of <relative-time>.

Alternatively, pin the time-elements@3.6.0 instead of latest.


Capture d’écran 2026-05-13 à 12 03 18

The `@github/time-element` library is now deprecated. Its authors
recommend using `@github/relative-time-element` instead.

This commit was motivated by the fact that Runboat uses the `<time-ago>`
and `time-elements@latest` library, which currently points to version
4.0.0.
In this release, the `<time-ago>` component was removed in favor of
`<relative-time>`.

Alternatively, pin the `time-elements@3.6.0` instead of `latest`.
@codecov

codecov Bot commented May 17, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 64.59%. Comparing base (8813f67) to head (2aff751).
⚠️ Report is 57 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #151      +/-   ##
==========================================
- Coverage   64.97%   64.59%   -0.39%     
==========================================
  Files          19       19              
  Lines        1245     1257      +12     
==========================================
+ Hits          809      812       +3     
- Misses        436      445       +9     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@Corentvn

Corentvn commented May 26, 2026

Copy link
Copy Markdown
Contributor Author

Hello @sbidoul,

I don't really get where I loose code coverage with this simple commit.
(Note: I'm not used to Codecov, but it seems it's not comparing the HEAD of this branch with HEAD of main but an older commit.)

Should we pin time-elements@3.6.0 instead of relative-time-element@latest ?

@sbidoul

sbidoul commented May 26, 2026

Copy link
Copy Markdown
Owner

Let's go with this. Thanks!

@sbidoul
sbidoul merged commit 7237e59 into sbidoul:main May 26, 2026
4 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants