fix auth on both domain.tld and *.domain.tld for ovh #5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello.
When adding both domain.tld and *.domain.tld to a certificate, the script is run 2 times, the TXT has the same key but a different value. Some people reported it in comments here :
https://blog.blaisot.org/letsencrypt-wildcard-part2.html
This is an fix attempt by comparing the TXT value to CERTBOT_VALIDATION and not just the existence of the record.
As my cert was already renewed, i did not test it on the final version of the script in real life conditions (I just know DNS edits looks ok).
Could possibly still fail : the refresh command "result = client.post('/domain/zone/' + certbot_domain + '/refresh')" may be ignored if ovh decide it's not good to call it very fast, so maybe the wait loop might timeout, even if everything is in place to validate the domain.