Skip to content

Remove unnecessary code in build files #486

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
eed3si9n merged 1 commit into from
Feb 25, 2026
+0 −22
Merged

Remove unnecessary code in build files #486

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions project/Dependencies.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,8 +2,6 @@ import sbt._
import Keys._

object Dependencies {
val scala212 = "2.12.21"
val scala213 = "2.13.18"
val scala3 = "3.7.4"

val scalaCompiler = Def.setting {
Expand Down
20 changes: 0 additions & 20 deletions project/HouseRulesPluglin.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,9 +12,7 @@ object HouseRulesPlugin extends AutoPlugin {
lazy val baseSettings: Seq[Def.Setting[?]] = Seq(
scalacOptions ++= Seq("-encoding", "utf8"),
scalacOptions ++= Seq("-deprecation", "-feature", "-unchecked"),
scalacOptions += "-language:higherKinds",
scalacOptions += "-language:implicitConversions",
scalacOptions ++= "-Xfuture".ifScala213OrMinus.value.toList,
scalacOptions ++= "-Werror"
.ifScala(v => {
sys.props.get("sbt.build.fatal") match {
Expand All @@ -24,30 +22,12 @@ object HouseRulesPlugin extends AutoPlugin {
})
.value
.toList,
scalacOptions ++= "-Xsource:3".ifScala213OrMinus.value.toList,
scalacOptions ++= "-Wconf:msg=package object inheritance is deprecated:warning".ifScala213OrMinus.value.toList,
scalacOptions ++= "-Yno-adapted-args".ifScala212OrMinus.value.toList,
scalacOptions ++= "-Ywarn-dead-code".ifScala213OrMinus.value.toList,
scalacOptions ++= "-Ywarn-numeric-widen".ifScala213OrMinus.value.toList,
scalacOptions ++= "-Ywarn-value-discard".ifScala213OrMinus.value.toList,
) ++ Seq(Compile, Test).flatMap(c =>
(c / console / scalacOptions) --= Seq("-Ywarn-unused-import", "-Xlint")
)

private def scalaPartV = Def setting (CrossVersion partialVersion scalaVersion.value)

private implicit final class AnyWithIfScala[A](val __x: A) {
def ifScala(p: Long => Boolean) =
Def setting (scalaPartV.value collect { case (2, y) if p(y) => __x })
def ifScalaLte(v: Long) = ifScala(_ <= v)
def ifScalaGte(v: Long) =
Def.setting(
scalaPartV.value.collect {
case (2, y) if y >= v => __x
case (n, _) if n >= 3 => __x
}
)
def ifScala212OrMinus = ifScalaLte(12)
def ifScala213OrMinus = ifScalaLte(13)
}
}