Skip to content

Fix warnings #235

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
eed3si9n merged 1 commit into from
Apr 25, 2026
Merged

Fix warnings #235

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions gpg-library/src/main/scala/com/jsuereth/pgp/PrivateKey.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -95,7 +95,7 @@ class SecretKey(val nested: PGPSecretKey) {
sGen.init(PGPSignature.BINARY_DOCUMENT, pgpPrivKey)
for (name <- this.publicKey.userIDs) {
val spGen = new PGPSignatureSubpacketGenerator()
spGen.setSignerUserID(false, name)
spGen.addSignerUserID(false, name)

@xuwei-k xuwei-k Apr 25, 2026

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://github.com/bcgit/bc-java/blob/1ff948a06c344932e93cc8e188dd06957e9e6887/pg/src/main/java/org/bouncycastle/openpgp/PGPSignatureSubpacketGenerator.java#L377-L381

sGen.setHashedSubpackets(spGen.generate())
}
val cGen = new PGPCompressedDataGenerator(CompressionAlgorithmTags.ZLIB)
Expand Down Expand Up @@ -149,9 +149,9 @@ class SecretKey(val nested: PGPSecretKey) {
sGen.generateOnePassVersion(false).encode(bOut)
val spGen = new PGPSignatureSubpacketGenerator()
val isHumanReadable = true
spGen.setNotationData(true, isHumanReadable, notation._1, notation._2)
spGen.addNotationData(true, isHumanReadable, notation._1, notation._2)

@xuwei-k xuwei-k Apr 25, 2026

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://github.com/bcgit/bc-java/blob/1ff948a06c344932e93cc8e188dd06957e9e6887/pg/src/main/java/org/bouncycastle/openpgp/PGPSignatureSubpacketGenerator.java#L489-L494

// TODO - Embedd this key's signatures?
userIDs.headOption foreach (spGen.setSignerUserID(false, _))
userIDs.headOption foreach (spGen.addSignerUserID(false, _))

@xuwei-k xuwei-k Apr 25, 2026

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://github.com/bcgit/bc-java/blob/1ff948a06c344932e93cc8e188dd06957e9e6887/pg/src/main/java/org/bouncycastle/openpgp/PGPSignatureSubpacketGenerator.java#L377-L381


val packetVector = spGen.generate()
sGen.setHashedSubpackets(packetVector)
Expand Down
4 changes: 2 additions & 2 deletions gpg-library/src/main/scala/com/jsuereth/pgp/PublicKey.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,13 +18,13 @@ class PublicKey(val nested: PGPPublicKey) extends PublicKeyLike with StreamingSa
def bitStrength = nested.getBitStrength
def creationTime = nested.getCreationTime
def fingerprint = nested.getFingerprint
def isRevoked = nested.isRevoked
def isRevoked = nested.hasRevocation

@xuwei-k xuwei-k Apr 25, 2026

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://github.com/bcgit/bc-java/blob/1ff948a06c344932e93cc8e188dd06957e9e6887/pg/src/main/java/org/bouncycastle/openpgp/PGPPublicKey.java#L812-L816

def algorithm = nested.getAlgorithm
def algorithmName = nested.getAlgorithm match {
case PublicKeyAlgorithmTags.RSA_ENCRYPT | PublicKeyAlgorithmTags.RSA_GENERAL | PublicKeyAlgorithmTags.RSA_SIGN =>
"RSA"
case PublicKeyAlgorithmTags.DSA => "DSA"
case PublicKeyAlgorithmTags.EC => "EC"
case PublicKeyAlgorithmTags.ECDH => "EC"

@xuwei-k xuwei-k Apr 25, 2026

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://github.com/bcgit/bc-java/blob/1ff948a06c344932e93cc8e188dd06957e9e6887/pg/src/main/java/org/bouncycastle/bcpg/PublicKeyAlgorithmTags.java#L40-L47

case PublicKeyAlgorithmTags.ELGAMAL_ENCRYPT | PublicKeyAlgorithmTags.ELGAMAL_GENERAL => "ElGamal"
case PublicKeyAlgorithmTags.ECDSA => "ECDSA"
case _ => "Unknown"
Expand Down