Draft
Conversation
Contributor
Good point. I agree making things easy across git crlf settings makes sense. Then we can have a dedicated test that checks for line endings (perhaps just searching for crlf strings in the output, ignoring the 'real' contents?)
Maybe add an issue for this upstream? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Should we add a test for this? I have removed the "-w" option on diff but I think it would be better to leave that in because git crlf could be configured differently for different users making it harder for them to run the tests.
Sadly the PrettyPrinter in CycloneDX is hardcoded and always uses the systems default line endings.
Fixes #76