fix warnings - #1595
Merged
Merged
Conversation
xuwei-k
commented
Sep 20, 2025
| val varArgPosition = if (varArgs) paramTypes.length - 1 else -1 | ||
| val isVarArg = List.tabulate(paramTypes.length)(_ == varArgPosition) | ||
| val pa = (paramAnnots, paramTypes, isVarArg).zipped map { | ||
| val pa = paramAnnots.lazyZip(paramTypes).lazyZip(isVarArg).map { |
Member
Author
There was a problem hiding this comment.
[warn] -- Deprecation Warning: /home/runner/work/zinc/zinc/internal/zinc-apiinfo/src/main/scala/sbt/internal/inc/ClassToAPI.scala:387:49
[warn] 387 | val pa = (paramAnnots, paramTypes, isVarArg).zipped map {
[warn] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[warn] |method zipped in class Ops is deprecated since 2.13.0: Use xs.lazyZip(ys).lazyZip(zs)
xuwei-k
commented
Sep 20, 2025
| unorderedHash(new HashIterator(ts.iterator)) | ||
| case _ => | ||
| unorderedHash(ts.toList.map { t => | ||
| unorderedHash(ts.iterator.to(List).map { t => |
Member
Author
There was a problem hiding this comment.
[warn] -- Deprecation Warning: /home/runner/work/zinc/zinc/internal/zinc-apiinfo/src/main/scala/xsbt/api/HashAPI.scala:159:25
[warn] 159 | unorderedHash(ts.toList.map { t =>
[warn] | ^^^^^^^^^
[warn] |method toList in class IterableOnceExtensionMethods is deprecated since 2.13.0: Use .iterator.to(List) instead
xuwei-k
commented
Sep 20, 2025
| } | ||
|
|
||
| private var tempDir: Path = _ | ||
| private var tempDir: Path = compiletime.uninitialized |
Member
Author
There was a problem hiding this comment.
[warn] -- Warning: /home/runner/work/zinc/zinc/internal/zinc-classfile/src/main/scala/sbt/internal/inc/JarUtils.scala:277:30
[warn] 277 | private var tempDir: Path = _
[warn] | ^
[warn] |`= _` has been deprecated; use `= uninitialized` instead.
[warn] |`uninitialized` can be imported with `scala.compiletime.uninitialized`.
xuwei-k
commented
Sep 20, 2025
| import xsbti.ArtifactInfo.ScalaOrganization | ||
| import sbt.io.IO | ||
| import scala.language.reflectiveCalls | ||
| import scala.reflect.Selectable.reflectiveSelectable |
Member
Author
There was a problem hiding this comment.
[warn] -- Deprecation Warning: /home/runner/work/zinc/zinc/internal/zinc-classpath/src/main/scala/sbt/internal/inc/ScalaInstance.scala:211:72
[warn] 211 | case p: ScalaProvider2 @unchecked => Option((provider.loader, p.loaderLibraryOnly))
[warn] | ^
[warn] |method reflectiveSelectableFromLangReflectiveCalls in object Selectable is deprecated since 3.0: import scala.reflect.Selectable.reflectiveSelectable instead of scala.language.reflectiveCalls
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.