update contract sort order in numberic way#1032
Merged
technophile-04 merged 2 commits intomainfrom Jan 16, 2025
Merged
Conversation
Pabl0cks
approved these changes
Jan 14, 2025
Collaborator
Pabl0cks
left a comment
There was a problem hiding this comment.
Tested and is working nicely to me 🙏
rin-st
approved these changes
Jan 14, 2025
Member
rin-st
left a comment
There was a problem hiding this comment.
Works great! Just added one question
Collaborator
Author
|
Thanks Pablo and Rinat, Just added a comment but we happy to go with |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
This sorts in natural number order.
In main branch: Contract1, Contract11 and then Contract2 will appear in debug page
We implemented this logic in https://github.com/BuidlGuidl/ctf.buidlguidl.com/blob/e5f418f7bd1ac942f99f49e689101c53ae6b5f78/packages/nextjs/app/debug/_components/DebugContracts.tsx#L12-L14
To test:
Contract1.sol
Contract2.sol
Contract11.sol
00_deploy_your_contracts.ts00_deploy_your_contract.ts