Fixed retry and duplicated replacements#3015
Open
Seetaramayya wants to merge 4 commits intoscala-steward-org:mainfrom
Open
Fixed retry and duplicated replacements#3015Seetaramayya wants to merge 4 commits intoscala-steward-org:mainfrom
Seetaramayya wants to merge 4 commits intoscala-steward-org:mainfrom
Conversation
Member
This deserves its own PR. I would also prefer to have a test for that in |
Contributor
Author
|
Another PR crated to address the other issue #3016 |
Contributor
Author
|
Are you going to merge this PR? |
|
In order to make this PR mergeable, you must resolve the conflicts first. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For good amount of time our
scala-stewardjobs are failing. Following changes fixed in our case, so creating the PR, might be useful port the changes to the main repo.I hope this PR address the issue #2934
New Retry logic
Retry-Afterheader present, then use the header value to retry (this was there before)X-Ratelimit-Resetheader. Header value is UTC epoch seconds. Here I took some assumptions60 seconds. That means max wait time would be60 seconds.1 second1.secondHere is the github suggested best-practices
Another issueIf there are duplicated replacements then the job was failing with.StringIndexOutOfBoundsException. Added unit test to verify the behaviour