Skip to content

fix: Grouped PR description must not include updates ignored via // scala-steward:off#3594

Merged
alejandrohdezma merged 1 commit intoscala-steward-org:mainfrom
jospint:fixGroupedPRDescriptions
Mar 19, 2025
Merged

fix: Grouped PR description must not include updates ignored via // scala-steward:off#3594
alejandrohdezma merged 1 commit intoscala-steward-org:mainfrom
jospint:fixGroupedPRDescriptions

Conversation

@jospint
Copy link
Copy Markdown
Contributor

@jospint jospint commented Mar 2, 2025

Attempt to fix #3138

@jospint jospint marked this pull request as ready for review March 2, 2025 11:52
@jospint jospint force-pushed the fixGroupedPRDescriptions branch 2 times, most recently from fb8c001 to 3967e69 Compare March 7, 2025 14:16
@jospint jospint force-pushed the fixGroupedPRDescriptions branch from 3967e69 to 7f845a8 Compare March 14, 2025 14:18
@jospint
Copy link
Copy Markdown
Contributor Author

jospint commented Mar 19, 2025

I made this PR a couple of weeks ago, but I haven't heard back from the people who initially looked into the issue.
@fthomas I assume that you are the main maintainer of the repository, could you take a look into it? I'm happy to work on any changes.

Copy link
Copy Markdown
Member

@alejandrohdezma alejandrohdezma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for the fix!

@codecov
Copy link
Copy Markdown

codecov Bot commented Mar 19, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.83%. Comparing base (f0dfaa6) to head (7f845a8).
Report is 92 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3594      +/-   ##
==========================================
+ Coverage   89.80%   89.83%   +0.02%     
==========================================
  Files         174      174              
  Lines        5031     5045      +14     
  Branches      493      495       +2     
==========================================
+ Hits         4518     4532      +14     
  Misses        513      513              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@alejandrohdezma alejandrohdezma merged commit a5997d1 into scala-steward-org:main Mar 19, 2025
10 checks passed
@jospint jospint deleted the fixGroupedPRDescriptions branch March 21, 2025 14:23
@jospint jospint mentioned this pull request May 26, 2025
@fthomas fthomas added this to the 0.34.0 milestone Jun 6, 2025
@fthomas fthomas added the bug Something isn't working label Jun 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Grouped PR description includes updates ignored via // scala-steward:off

3 participants