Skip to content

Add tests for pullRequests.grouping syntax#3654

Merged
rtyley merged 1 commit intoscala-steward-org:mainfrom
guardian:add-tests-to-clarify-pullRequests.grouping-syntax
Jul 6, 2025
Merged

Add tests for pullRequests.grouping syntax#3654
rtyley merged 1 commit intoscala-steward-org:mainfrom
guardian:add-tests-to-clarify-pullRequests.grouping-syntax

Conversation

@rtyley
Copy link
Copy Markdown
Contributor

@rtyley rtyley commented Jun 13, 2025

A colleague mentioned to me that some of our pullRequests.grouping were not pulling in all the artifacts we were expecting - while looking into this, I realised that I wasn't 100% clear on where wildcards could be used in pullRequests.grouping, so I wrote this test to exercise all the cases that were relevant to us, and see what worked - this may be tested elsewhere to some extent in the Scala Steward codebase, but I think it's helpful to drill into the specific functionality with these new tests on PullRequestUpdateFilter.

Note that the tests only assert the behaviour is what it is (meaning config parsing behaviour is tested to be consistent over time), not what it might 'ideally' be. By that, I mean that for myself, it would be ideal if the matching behaviour automatically included all sub-domains - so a filter of com.gu would match com.gu, com.gu.play-secret, com.gu.foo.bar etc, but not com.gumbo (because it's not a subdomain of com.gu) - but improving that behaviour would potentially affect how existing .scala-steward.conf files are interpreted - see "Matching group-&-sub-group-ids" in #3655.

rtyley added a commit to guardian/scala-steward-public-repos that referenced this pull request Jun 13, 2025
@rtyley rtyley force-pushed the add-tests-to-clarify-pullRequests.grouping-syntax branch from 82650b4 to af9a7e4 Compare June 13, 2025 13:20
rtyley added a commit to guardian/scala-steward-public-repos that referenced this pull request Jun 13, 2025
@rtyley rtyley changed the title Add tests to clarify pullRequests.grouping syntax Add tests for pullRequests.grouping syntax Jun 13, 2025
@rtyley rtyley force-pushed the add-tests-to-clarify-pullRequests.grouping-syntax branch from af9a7e4 to 942528d Compare June 13, 2025 14:24
@codecov
Copy link
Copy Markdown

codecov Bot commented Jun 13, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.83%. Comparing base (083ed69) to head (942528d).
Report is 24 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3654   +/-   ##
=======================================
  Coverage   89.83%   89.83%           
=======================================
  Files         174      174           
  Lines        5045     5045           
  Branches      495      495           
=======================================
  Hits         4532     4532           
  Misses        513      513           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@rtyley rtyley marked this pull request as ready for review June 13, 2025 16:04
@rtyley rtyley merged commit 26d54ba into scala-steward-org:main Jul 6, 2025
10 checks passed
@mzuehlke mzuehlke added this to the 0.35.0 milestone Jul 6, 2025
@rtyley rtyley deleted the add-tests-to-clarify-pullRequests.grouping-syntax branch November 28, 2025 11:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants