Use bitbucket static user for bitbucket git auth#3851
Open
SantiarErhi wants to merge 4 commits intoscala-steward-org:mainfrom
Open
Use bitbucket static user for bitbucket git auth#3851SantiarErhi wants to merge 4 commits intoscala-steward-org:mainfrom
SantiarErhi wants to merge 4 commits intoscala-steward-org:mainfrom
Conversation
For more info regarding bitbucket static user see: https://support.atlassian.com/bitbucket-cloud/docs/using-api-tokens/
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3851 +/- ##
==========================================
- Coverage 90.39% 90.37% -0.02%
==========================================
Files 177 177
Lines 5110 5111 +1
Branches 458 422 -36
==========================================
Hits 4619 4619
- Misses 491 492 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Author
|
Bitbucket auth logic has been moved to separate class in order to not change logic for ALL ForgeTypes using BasicAuthAlg. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bitbucket App password will be disabled in 2.5 months (see https://www.atlassian.com/blog/bitbucket/bitbucket-cloud-enters-phase-2-of-app-password-deprecation). Since API token usage is inconsistent between bitbucket.org used for cloning repositories and api.bitbucket.org/2.0 used for working with PRs, etc (see https://support.atlassian.com/bitbucket-cloud/docs/using-api-tokens/), it's impossible to use API tokens with scala-steward and be able to clone a repository and read/write pull requests.
In order not to write another CLI option to specify another user for git or api, this solution uses static user name feature (see https://support.atlassian.com/bitbucket-cloud/docs/using-api-tokens/#Include-the-API-token-in-the-URL).
It works for me, but I'm not sure whether it's an appropriate solution.