Conversation
emdash-ie
reviewed
Apr 7, 2026
| import org.scalasteward.core.{git, util} | ||
| import org.typelevel.log4cats.Logger | ||
|
|
||
| case class ApplicableUpdateSet(edits: List[Substring.Replacement], artifactUpdates: List[Update.ForArtifactId]) { |
Contributor
There was a problem hiding this comment.
I’d like to propose EquivalentUpdateSet or UpdatesForGivenEdit as the name for this instead of ApplicableUpdateSet. I find the existing name hard to immediately find a meaning for when I read it, and I think the most important thing about these sets of updates is that they’re produced by the same edits.
Contributor
Author
There was a problem hiding this comment.
Ah good suggestion Emily! I like UpdatesForGivenEdit, I've done this with commit 1574d0c.
rtyley
force-pushed
the
group-updates-by-edit
branch
from
6c7bcc8 to
a87a2eb
Compare
rtyley
added a commit
that referenced
this pull request
Apr 12, 2026
As suggested by Emily: #3852 (comment) ...the most important thing about these sets of updates is that they’re produced by the same edits.
Co-authored-by: Jamie B <53781962+JamieB-gu@users.noreply.github.com>
As suggested by Emily: #3852 (comment) ...the most important thing about these sets of updates is that they’re produced by the same edits.
rtyley
force-pushed
the
group-updates-by-edit
branch
from
3811557 to
ad6d05f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes two issues:
com.fasterxml.jackson.corecom.fasterxml.jackson.datatypeSee also:
Update.ForGroupIdgrouping so it can group together varying subgroup ids for a common parent group #3803