Skip to content

Use flexible types in dotty #21608

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
May 14, 2025
Merged

Use flexible types in dotty #21608

merged 3 commits into from
May 14, 2025
+126 −168

Conversation

noti0na1
Copy link
Member

@noti0na1 noti0na1 commented Sep 18, 2024 •
edited
Loading

No description provided.

@noti0na1 noti0na1 changed the title Enable flexible types in dotty Use flexible types in dotty Sep 18, 2024
@noti0na1 noti0na1 force-pushed the enable-flexible-types-in-dotty branch from af80b4e to e60dcbb Compare September 23, 2024 12:58
@noti0na1
Copy link
Member Author

noti0na1 commented Oct 8, 2024 •
edited
Loading

Hi @hamzaremmal , can you give write permission of staging to @HarrisL2 , who is a master student supervised by @olhotak ? so we can collaborate on this PR.

@hamzaremmal
Copy link
Member

Hi @hamzaremmal , can you give write permission of staging to @HarrisL2 , who is a master student supervised by @olhotak ? so we can collaborate on this PR.

Hi @noti0na1, @HarrisL2 should have received an invite !

@noti0na1 noti0na1 force-pushed the enable-flexible-types-in-dotty branch from e60dcbb to dbd1db4 Compare November 13, 2024 14:43
@olhotak
Copy link
Contributor

olhotak commented May 13, 2025

@noti0na1 This is still marked as draft. What is the status of this PR from your point of view?

@hamzaremmal Could you please also give access to staging to @SuperCl4sh so he can also contribute to this PR?

@noti0na1
Copy link
Member Author

@noti0na1 This is still marked as draft. What is the status of this PR from your point of view?

I can rebase and update this PR, then let's migrate other files in a different PR?

@noti0na1 noti0na1 self-assigned this May 14, 2025
@olhotak
Copy link
Contributor

olhotak commented May 14, 2025

OK. I should have been clearer with my question: I wanted to know whether you considered this set of files finished and ready for review/merge, or whether you got stuck on something after porting these files.

@noti0na1
Copy link
Member Author

Not stuck on anything. They should be ready for review.

@noti0na1 noti0na1 force-pushed the enable-flexible-types-in-dotty branch from dbd1db4 to fbd1eeb Compare May 14, 2025 12:51
@noti0na1 noti0na1 marked this pull request as ready for review May 14, 2025 12:53
@noti0na1 noti0na1 requested a review from olhotak May 14, 2025 12:56
olhotak
olhotak approved these changes May 14, 2025
View reviewed changes
Copy link
Contributor

@olhotak olhotak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Otherwise LGTM.

@noti0na1 noti0na1 merged commit da9cc38 into scala:main May 14, 2025
30 checks passed
@noti0na1 noti0na1 deleted the enable-flexible-types-in-dotty branch May 14, 2025 19:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@olhotak olhotak olhotak approved these changes

Assignees

@noti0na1 noti0na1

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@noti0na1 @hamzaremmal @olhotak