-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Add experimental NamedTuple copyFrom method #23135
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
bishabosha
wants to merge
2
commits into
scala:main
Choose a base branch
from
dotty-staging:nt-copy
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+152
−4
Open
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,16 @@ | ||
//> using options -experimental | ||
|
||
trait Mod | ||
|
||
given Conversion[String, Mod] = _ => new Mod {} | ||
|
||
type Foo = (name: String, mod: Mod) | ||
case class Foo0(name: String, mod: Mod) | ||
|
||
@main def Test = | ||
val foo: Foo = (name = "foo", mod = "some_mod") | ||
val foo_updated: Foo = foo.copyFrom((mod = "bar")) // error, stays as String | ||
|
||
|
||
val foo0: Foo0 = Foo0(name = "foo", mod = "some_mod") | ||
val foo0_updated: Foo0 = foo0.copy(mod = "bar") // ok - does the conversion |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,29 @@ | ||
//> using options -experimental | ||
|
||
type City = (name: String, zip: Int, pop: Int) | ||
type Coord = (x: Double, y: Double) | ||
type Labels = (x: String, y: String) | ||
|
||
@main def Test = | ||
val city: City = (name = "Lausanne", zip = 1000, pop = 140000) | ||
val coord: Coord = (x = 1.0, y = 0.0) | ||
val labels: Labels = (x = "west", y = "north") | ||
|
||
// first field updated | ||
val coord_update = coord.copyFrom((x = 2.0)) | ||
val _: Coord = coord_update | ||
assert(coord_update.x == 2.0 && coord_update.y == 0.0) | ||
|
||
// last field updated | ||
val city_update = city.copyFrom((pop = 150000)) | ||
val _: City = city_update | ||
assert(city_update.name == "Lausanne" && city_update.zip == 1000 && city_update.pop == 150000) | ||
|
||
// replace field types | ||
val coord_to_labels = coord.copyFrom((x = "east", y = "south")) | ||
val _: Labels = coord_to_labels | ||
assert(coord_to_labels.x == "east" && coord_to_labels.y == "south") | ||
|
||
// out of order | ||
val city_update2 = city.copyFrom((pop = 150000, name = "Lausanne", zip = 1000)) | ||
val _: City = city_update2 |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
here is a demo of the limitation of no target typing, which I guess could be mitigated with a dedicated feature, or a secondary library solution based on lenses