Skip to content

Improve Unit ascription escape hatch #23147

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

som-snytt
Copy link
Contributor

Fixes #23145

I typoed my branch name.

As in Scala 2, use TreeInfo to deal with the hassle of adapted trees.

The interesting case is this.m which is a lossy adaptation. The attachments must be copied.

@som-snytt som-snytt force-pushed the issue/23045-value-discard branch from 162703a to deb3c14 Compare May 13, 2025 20:04
@som-snytt som-snytt force-pushed the issue/23045-value-discard branch from deb3c14 to 9e18bfe Compare May 13, 2025 20:10
@som-snytt
Copy link
Contributor Author

Forgot to update the check file when line numbers changed. Possibly the check file is useful for checking that the warning "looks good" (carets are correct, types are printed in desired form).

@som-snytt som-snytt marked this pull request as ready for review May 14, 2025 02:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

False postive discarded non-Unit value ... Add : Unit to discard silently
1 participant