Make hashcode of enum items stable #23218
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: anna herlihy <[email protected]> Co-authored-by: Miguel Trigueira <[email protected]>
mbovel
commented
May 21, 2025
| @@ -116,6 +116,12 @@ class SyntheticMembers(thisPhase: DenotTransformer) { | |||
| def syntheticDefIfMissing(sym: Symbol): List[Tree] = | |||
| if (existingDef(sym, clazz).exists) Nil else syntheticDef(sym) :: Nil | |||
|
|
|||
| def identifierRef: Tree = | |||
There was a problem hiding this comment.
Note: this was just moved from an inner scope. No changes.
|
I think a proper check should show different cases have different hashes and also if you have a case with an argument that two instances with the same argument have the same hash. |
|
@soronpo I added both tests. This PR only changes the hashcode of "enum values" (cases without parentheses), but it's probably still good to test the other cases as well. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #19177. Done during the compiler issue spree of Monday, May 19th.
Note:
hashCodeofStringis cached (see https://github.com/openjdk/jdk/blob/master/src/java.base/share/classes/java/lang/String.java#L2403-L2436), so this change should not introduce a significant performance overhead.