Unused lint does not rewrite suppressed warnings #24055
Open
+23
−10
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
som-snytt
force-pushed
the
issue/24009-rewrite-import-wconf
branch
from
5706106 to
8c198cf
Compare
som-snytt
force-pushed
the
issue/24009-rewrite-import-wconf
branch
from
8c198cf to
a7a8f7a
Compare
Partially duplicates reporter logic; reporter could auto-apply actions, maybe keying off diagnostic ID.
Instead of testing whether to emit actions by probing suppressions, just let the reporter apply LintWarning actions when the warning is actually reported.
som-snytt
force-pushed
the
issue/24009-rewrite-import-wconf
branch
from
a7a8f7a to
82fe265
Compare
|
I tried to strike a better balance in verbosity in the PR comment. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #24009
Why was the ticket worth tackling?
-Wconfallows users to control which optional warnings are reported, which is convenient for limiting noise and essential under-Werror. However, unwanted lints are destructive under-rewrite.How I fixed it
Instead of gating at the lint (for unused imports), enhance the reporter to apply code actions for lint warnings.
Why is this PR worth reviewing?
This PR turns out to be more complex in UX than in code.
What's the worse that could happen?
The code action in
CheckUnusedis always emitted when the lint is enabled. That could be noisy in an interactive environment that displays quickfixes.