Better error message: reassignment to val #24184
Conversation
odersky
force-pushed
the
reassignment-errormsg
branch
from
19342cf to
09086bf
Compare
| def booleanExpected = pt.isRef(defn.BooleanClass) | ||
| def booleanNote = | ||
| if booleanExpected then | ||
| ". Maybe you meant to write an equality test using `==`?" |
There was a problem hiding this comment.
or, for example, I intended to do <= for integers. I agree that having suggestions helps but I don't see where we draw the line for them. Going further, we could investigate further based on the types of lhs and rhs and suggest all the (2 characters methods ending (and starting?) with = that are compatible members)?
There was a problem hiding this comment.
Sure, just what did you mean would suggest for selections. did you mean Int.!=? or perhaps Int.<=? etc.
There was a problem hiding this comment.
Surely not. The suggestion is for a beginner who comes from a context where = means equality. We have to special case for this and not pollute the message with other suggestions.
We just had a talk here were someone proposed to introduce an educational subset of Scala because the students were too much put off by the current error message. That's the issue this PR addresses.
|
There is an aging improvement at #22869 |
3 participants
No description provided.