Replace REPL signal handling with raw mode jline terminal to make Ctrl-C handling work when REPL is a child process #24842
+55
−17
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rather than using JVM signal handling to trap the Ctrl-C, we instead make JLine set the terminal to raw mode and handle the Ctrl-C as a standard input character.
This is similar to what Ammonite (link) and (I think) JShell does, and has the advantage that it works even for
stdin/stdoutterminals inherited from parent processes (e.g. Mill or SBT) v.s. the current signal handling that only works when the REPL process is receiving the Ctrl-C directly.Fixes com-lihaoyi/mill#6452 downstream in Mill, tested manually by cherry picking onto
release-3.8.0, publishing locally, and using it in Mill