Support pattern match exhaustivity checks for quoted patterns #24940
+261
−6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jchyb
force-pushed
the
space-quoted-pattern-fixes
branch
2 times, most recently
from
1faed75 to
4e57c2c
Compare
jchyb
force-pushed
the
space-quoted-pattern-fixes
branch
from
4e57c2c to
a5a42bd
Compare
jchyb
force-pushed
the
space-quoted-pattern-fixes
branch
from
a5a42bd to
a238b5c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Turns out they were not supported altogether, so they would always warn. This could be hidden by the fact that the checks would not trigger for quoted.Type and quoted.Expr (but they still would for any product types containing them). Also confusing was the fact that extraction (
val '{$t} = '{0}) refutability checks would be called, and those are usually aligned with exhaustivity warnings. This is indeed what this PR tries to do.I will explain more later (for now let's just run the tests, I might also want to improve the reporting).
Fixes #24196