Fix false exhaustivity warning for GADT pattern matching #24973
+21
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
The test passed when I ran locally, looks like a flaky test. |
Contributor
|
That test is so flaky. I wish "someone" would adjust the CB to exclude it. Maybe it's not even the job of CB to run "every possible test". |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #24968
Since
Run[?]is not a subtype ofRun[String], minus(Typ(Run[?]),Prod(Run[String])) returnsTyp(Run[?]). This PR fixes false GADT exhaustivity warnings by allowingminusto inspect fields of the same case class, even without a subtype relationship