Make TypeMaps in Setup work correctly for fresh
#24985
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also, LocalCaps are no longer described as "fresh" in error messages.
- Introduce `fresh`
- New global definition: `caps.fresh`.
- `fresh` is for ResultCaps in function types.
- Disallow `fresh` outside result types of function types.
- Fix isTrackableRef: previously, a static term ref was trackable if its prefix was the ThisType
of a package, but was not trackable if the prefix was a TermRef to the same package.
Now both versions are trackable.
- Don't go to basetypes when comparing dependent functions at cc
- Improve printing of capabilities:
- Don't elide a universal capture set in a TypeMismatch message if one of its capabilities is mentioned
in an error note.
- Don't elide capture sets containing fresh when printing
- Don't use the verbose output for fresh if there are no open existentials
- Systematically backquote all entities shown as capabilities
odersky
changed the title
fresh
- Drop ToResultInResults - Move its functionality to separate methods in Setup - Implement dealias suppression logic for capset arguments. This is needed to be able to express referring with `fresh` to enclosing method types that don't immediately have the type containing the `fresh` as their result type.
odersky
force-pushed
the
fix-fresh-setup
branch
from
e508363 to
9ac63c6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is needed to be able to express referring with
freshto enclosing method typesthat don't immediately have the type containing the
freshas their result type.Based on #24923