Don't suggest invisible members of root imports #24999
Open
+37
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If some member from a root import is hidden by a subsequent import, don't suggest that member in a "did you mean?" clause.
odersky
added
the
better-errors
som-snytt
approved these changes
Jan 16, 2026
Contributor
som-snytt
left a comment
som-snytt
left a comment
There was a problem hiding this comment.
Otherwise, nice tweak && nice opportunity to glance at DidYouMean.
Co-authored-by: som-snytt <[email protected]>
SolalPirelli
approved these changes
Jan 16, 2026
Contributor
SolalPirelli
left a comment
SolalPirelli
left a comment
There was a problem hiding this comment.
Looks good. Just so I understand this better, is there a fundamental reason why DidYouMean has to partially reimplement the logic for finding things?
Contributor
Author
I think it's because in Typer we search for one name only, and do so in a highly optimized way. Whereas in DidyouMean we search for all members and then match them with the Levenshtein distance. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If some member from a root import is hidden by a subsequent import, don't suggest that member in a "did you mean?" clause.
Fixes #24995