Fix MatchError in wildcardArgOK for mixed wildcard/concrete type args #25001
+18
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #25000
The
wildcardArgOKfunction in overload resolution would crash with a MatchError when the argument type had mixed wildcard and concrete type arguments on an invariant type (e.g.,java.util.Map[String, ? <: V]).The partial function only handled
TypeBoundsbutStringis aTypeRef, causing the pattern match to fail. Added a general case that returnstrueif two types are same for non-wildcard arguments.Maybe we should return true here and defer their validation to the main
isCompatiblecheck?