Deprecation when inferring implicit from non-accessible companion#25516
Open
lrytz wants to merge 1 commit intoscala:mainfrom
Open
Deprecation when inferring implicit from non-accessible companion#25516lrytz wants to merge 1 commit intoscala:mainfrom
lrytz wants to merge 1 commit intoscala:mainfrom
Conversation
Implicits found in the companion object of a type should not be inferred if the companion object is not accessible. Deprecation as a first step before actually changing implicit inference.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implicits found in the companion object of a type should not be inferred if the companion object is not accessible.
Deprecation as a first step before actually changing implicit inference.
Ref #25347
The PR to change inference is #25367
How much have your relied on LLM-based tools in this contribution?
I asked it to turn my existing PR into a deprecation and cleaned it up manually. It wrote the test case, I verified it works by removing
// warnand adding an excess// warn.