Open
Conversation
Contributor
Author
|
The breakage was due to "variable pattern" in a typed pattern versus "define X" in a valdef. This appears simple, but currently it incorrectly accepts As a digression, maybe it should just officially accept I would have liked to add a new message with a non-trivial explanation, but the energy hump for introducing an error ID is much too high. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #25595
At
pattern1andvarDefOrDcl(which usespattern2), check that the optional ascription is legal. Accept arbitrary identifiers in pattern definitionscase id: T, which is already the case for the equivalentcase id @ (_: T).Correct the camelcase spelling of
Elsewhere.