Erase more aliases of Unit as result type to void.#26252
Open
sjrd wants to merge 1 commit into
Open
Conversation
The previous fix failed to take polymorphic type aliases into account. In general, it must hold that `A =:= B` implies `erase(A) =:= erase(B)` for all conditions of `erase`. So really the safest way is to test whether `tp =:= UnitType`.
Contributor
|
Seems like something isn't quite right in Scala.js tests with this 😅 |
Member
Author
|
Yes, and it's a symptom that it's not in agreement with what Scala 2 does, even for the JVM. It's just that Scala.js is one of the few hold outs in our build that actually links against Scala 2-produced code. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The previous fix failed to take polymorphic type aliases into account.
In general, it must hold that
A =:= Bimplieserase(A) =:= erase(B)for all conditions oferase. So really the safest way is to test whethertp =:= UnitType.Follow-up to #26192.
How much have you relied on LLM-based tools in this contribution?
Not at all
How was the solution tested?
New automated tests (including the issue's reproducer, if applicable)