Changes to usage leak detection and reporting#26253
Open
odersky wants to merge 2 commits into
Open
Conversation
This should help with keeping error messages more focused. I noted that programs that have regular capture check errors sometimes have strange leakage and separation errors in addition. We now suppress these and issue them only if all regular capture check errors are resolved.
Some went undetected before. And the logic that allowed uses inside boxing environments was missing.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two changes:
Report leakage errors and separation errors only if no errors previously
This should help with keeping error messages more focused.
I noted that programs that have regular capture check errors sometimes have strange
leakage and separation errors in addition. We now suppress these and issue them only
if all regular capture check errors are resolved.
Fix detection and reporting of LocalCap leaks
Some went undetected before. And the logic that allowed uses inside boxing environments was missing.
This will become more important when we drop reach capabilities, since then LocalCap leaks will become more common.