feat: add sbt.testing.Framework implementation for TestNG on classpath when needed #2606
Conversation
|
Not sure if this is the best approach or if the it should be added to the classpath only for running test... But then I'm not sure where to best cache the result. |
There was a problem hiding this comment.
Not sure if this is the best approach or if the it should be added to the classpath only for running test... But then I'm not sure where to best cache the result.
I think we are fine not caching it for now, this will only show up now when TestNG is used, right? One thing we could potentially do is not resolve it every time, so we can use val provider = BloopComponentCompiler.getComponentProvider(Paths.getCacheDirectory("testng")) similar to SemanticDBCache though a bit easier.
Could you add a test case to BspTestSpec ?
| val project = Project.fromConfig(testNGProjectConfig(logger), origin, logger) | ||
|
|
||
| val platform = project.platform.asInstanceOf[Platform.Jvm] | ||
| pprint.log(platform.classpath) |
There was a problem hiding this comment.
| pprint.log(platform.classpath) |
kasiaMarek
force-pushed
the
metals-i6826
branch
from
f44f37e to
072a91e
Compare
kasiaMarek
force-pushed
the
metals-i6826
branch
from
072a91e to
a0bb0f6
Compare
connected to: scalameta/metals#6826
Should bump mill version after com-lihaoyi/mill#4506 to get single test cases support.