Fix #2678: Handle projects with only resources - #2692
Merged
Conversation
added 3 commits
June 24, 2025 16:12
add test covering example copy resources in case of both java and scala sources are missing NOTE: this is POC
wiacekm
force-pushed
the
2678-only-resource-project
branch
from
June 24, 2025 14:24
53b72be to
6e6afe2
Compare
make case object instead of case class check case with java sources only
tgodzik
requested changes
Jun 25, 2025
tgodzik
left a comment
tgodzik
left a comment
Contributor
There was a problem hiding this comment.
Great work! Two minor comments from me
| compileProjectTracer.terminate() | ||
| Task.now(earlyResultBundle) | ||
| case Right(CopyResourcesOnly) => | ||
| val denylist = Set.empty[Path] // TODO: verify if it shouldn't be computed somehow |
Contributor
There was a problem hiding this comment.
I don't think we have anything that we don't want to copy, this is usually useful for invalidated sources. It's safe to set it to empty for this use case
I wonder if we should delete anything no longer available, but that might be a separate thing altogether.
Co-authored-by: Tomasz Godzik <tgodzik@users.noreply.github.com>
wiacekm
marked this pull request as ready for review
July 1, 2025 06:29
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bloop did not recognize projects that contain only resources and no Scala or Java sources. This change ensures that such projects are correctly handled by copying resources even when no sources are present.