Initial work towards compiler plugin support: Update docs and add test placeholder - #1573
Initial work towards compiler plugin support: Update docs and add test placeholder#1573vidishagawas121 wants to merge 2 commits into
Conversation
|
@adpi2 @kannukalra this is a small initial PR to help understand the codebase for GSoC 2025 project idea (https://github.com/scalacenter/scaladex/) |
adpi2
left a comment
adpi2
left a comment
There was a problem hiding this comment.
Overall, it looks good. I see that you found your way in the codebase.
Before merging, I would like you to revert the change from ssh to https in git modules.
| url = git@github.com:scalacenter/scaladex-small-index.git | ||
| url = https://github.com/scalacenter/scaladex-small-index.git | ||
| [submodule "contrib"] | ||
| path = contrib | ||
| url = git@github.com:scalacenter/scaladex-contrib.git | ||
| url = https://github.com/scalacenter/scaladex-contrib.git |
There was a problem hiding this comment.
ssh and https are both valid and I prefer to keep ssh, as it was before. If you don't know how to set up ssh you can read this Github documentation page. Alternatively, you can configure a replacement of the ssh url to the https url in your configuration, as explained here.
There was a problem hiding this comment.
thank you! I will look into it and make the changes
| // val cases = Table( | ||
| // ("input", "target"), | ||
| // ("_2.13.10", BinaryVersion(CompilerPlugin, Scala(Version(2, 13, 10)))), | ||
| // ("_3.3.1", BinaryVersion(CompilerPlugin, Scala(Version(3, 3, 1)))) | ||
| // ) |
|
@adpi2 reverted the changes that you had said |
|
@vidishagawas121 thank you for the revert. Unfortunately the CI fails because of formatting. Could you run |
|
sure! I will do it |
2 participants
Initial work towards compiler plugin support
This PR lays the groundwork for adding compiler plugin support to Scaladex by improving documentation and setting up test placeholders.
Changes Made
Documentation Updates
Updated README.md:
Enhanced BinaryVersion.scala:
Added Test Infrastructure:
Implementation Plan
The following steps are planned for full compiler plugin support:
Related Information
This work is part of a larger effort to improve Scaladex's support for compiler plugins, which currently use full Scala versions (e.g., _2.13.10) and require special handling.
Testing
Checklist