add scalafix-loader supporting version & deps in .scalafix.conf - #2236
Draft
bjaglin wants to merge 3 commits into
Draft
add scalafix-loader supporting version & deps in .scalafix.conf#2236bjaglin wants to merge 3 commits into
bjaglin wants to merge 3 commits into
Conversation
bjaglin
changed the title
bjaglin
force-pushed
the
versions-in-conf
branch
from
April 20, 2025 14:47
21d01d0 to
b2e3121
Compare
bjaglin
force-pushed
the
versions-in-conf
branch
7 times, most recently
from
April 27, 2025 12:56
fbaeeb5 to
0736e12
Compare
bjaglin
changed the title
bjaglin
force-pushed
the
versions-in-conf
branch
6 times, most recently
from
April 27, 2025 23:50
95827f3 to
18e287f
Compare
bjaglin
changed the title
bjaglin
force-pushed
the
versions-in-conf
branch
8 times, most recently
from
May 4, 2025 19:13
9bba45b to
1bceae9
Compare
bjaglin
force-pushed
the
versions-in-conf
branch
2 times, most recently
from
May 8, 2025 14:36
90c6fcb to
68ab37a
Compare
bjaglin
force-pushed
the
versions-in-conf
branch
2 times, most recently
from
May 8, 2025 19:51
34b4f36 to
cff3f67
Compare
An old scalafix-interfaces client should be able to get the full Scala version for a recent scalafix-cli version. This is achieved by encapsulating property file lookup behind a Java interface, for which an implementation can easily be retrieved via ServiceLoader, as long as the recent scalafix-versions JAR has been fetched.
bjaglin
force-pushed
the
versions-in-conf
branch
2 times, most recently
from
May 11, 2025 10:05
d92cad8 to
692834a
Compare
Add implementation of Scalafix & ScalafixArguments in new project, with support for targeting a different scalafix-cli version, based on an optional scalafix version in .scalafix.conf. That scalafix-cli version is fetched and loaded via service provider when one of the non-with method is invoked, and initialized with all accumulated parameters.
bjaglin
commented
May 11, 2025
| .settings( | ||
| moduleName := "scalafix-versions", | ||
| javaSettings, | ||
| mimaPreviousArtifacts := Set.empty, // TODO: remove after 0.14.4 |
bjaglin
commented
May 11, 2025
| .settings( | ||
| moduleName := "scalafix-loader", | ||
| javaSettings, | ||
| mimaPreviousArtifacts := Set.empty, // TODO: remove after 0.14.4 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Helps for scalacenter/sbt-scalafix#482
Towards #1146 & joan38/mill-scalafix#239
Revisits #2226 & #2231, reverted in #2240