Conversation
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Tip Issue Planner is now in beta. Read the docs and try it out! Share your feedback on Discord. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
tgodzik
left a comment
tgodzik
left a comment
There was a problem hiding this comment.
Thanks for raising this!
| * Convert a semanticdb symbol to an import path. | ||
| * E.g., "scala/collection/immutable/List#" -> "scala.collection.immutable.List" | ||
| */ | ||
| private def symbolToFqcn(symbol: String): String = { |
There was a problem hiding this comment.
I think most of this got rewritten and replaced on main. The logic was flaky unfortunately, could you check the newest version instead?
There was a problem hiding this comment.
I've applied newer changes from the main branch.
| import org.eclipse.lsp4j.DiagnosticSeverity | ||
|
|
||
| object DiagnosticsProvider { | ||
| def getDiagnostics( |
There was a problem hiding this comment.
Don't we already return compiler diagnostics for Metals 2? I think we don't need to add this.
There was a problem hiding this comment.
Yeah, we probably don't need it, I've removed it.
| params.token() | ||
| ) { pc => | ||
| val compiler = pc.compiler(params) | ||
| if (params.shouldReturnDiagnostics()) { |
There was a problem hiding this comment.
Could you check if there is nothing in m2 that already handles the diagnostics? Should probably be do on didChange, maybe we can use the same approach
tgodzik
left a comment
tgodzik
left a comment
There was a problem hiding this comment.
Could you look at the failing tests? Also scalafix and scalafmt is failing. You can just run both sbt scalafixAll and './bin/scalafmt'
mkoteckivl
force-pushed
the
add_imports_on_paste_v2
branch
2 times, most recently
from
21cf195 to
cfb46a3
Compare
mkoteckivl
force-pushed
the
add_imports_on_paste_v2
branch
from
cfb46a3 to
9c96546
Compare
2 participants
based mostly on PR#7542