-
Notifications
You must be signed in to change notification settings - Fork 414
feat: Add stdio transport support for Metals MCP server #8266
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 7 commits
Commits
Show all changes
15 commits
Select commit
Hold shift + click to select a range
6d15a18
feat: Add stdio transport support for Metals MCP server
majk-p b6a7cbe
refactor MCP - extract shared parts
majk-p 897093e
drop manual test script
majk-p 4cc73f6
fix tests
majk-p 1437a4f
refactor
majk-p 12418f0
address review comments
majk-p 3c0ed4a
address review comments
majk-p 20e1419
scalafix
majk-p d0b0edd
increase timeout to fix test
majk-p 53ef51e
fix unit tests
majk-p b2aa8bf
drop unused methods
majk-p 3d91fb9
address review comments and fix tests
majk-p 3a2b854
use transport instead of useStdio parameter
majk-p 0716559
deduplicate test logic for mcp
majk-p 95dd824
block until initialization is finished
majk-p File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
43 changes: 43 additions & 0 deletions
43
metals/src/main/scala/scala/meta/internal/metals/mcp/McpExceptions.scala
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,43 @@ | ||
| package scala.meta.internal.metals.mcp | ||
|
|
||
| object McpMessages { | ||
|
|
||
| object FindDep { | ||
|
|
||
| def versionMessage(completed: Option[String]): String = { | ||
| s"""|Latest version found: ${completed.getOrElse("none")} | ||
| |""".stripMargin | ||
| } | ||
|
|
||
| def dependencyReturnMessage( | ||
| key: String, | ||
| completed: Seq[String], | ||
| ): String = { | ||
| s"""|Tool managed to complete `$key` field and got potential values to use for it: ${completed.mkString(", ")} | ||
| |""".stripMargin | ||
| } | ||
|
|
||
| def noCompletionsFound: String = | ||
| "No completions found" | ||
| } | ||
| } | ||
|
|
||
| sealed trait IncorrectArgumentException extends Exception | ||
|
|
||
| class MissingArgumentException(key: String) | ||
| extends Exception(s"Missing argument: $key") | ||
| with IncorrectArgumentException | ||
|
|
||
| class IncorrectArgumentTypeException(key: String, expected: String) | ||
| extends Exception(s"Incorrect argument type for $key, expected: $expected") | ||
| with IncorrectArgumentException | ||
|
|
||
| class InvalidSymbolTypeException(invalid: Seq[String], validTypes: String) | ||
| extends Exception( | ||
| s"Invalid symbol types: ${invalid.mkString(", ")}. Valid types are: $validTypes" | ||
| ) | ||
| with IncorrectArgumentException | ||
|
|
||
| object MissingFileInFocusException | ||
| extends Exception(s"Missing fileInFocus and failed to infer it.") | ||
| with IncorrectArgumentException |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.