Update thinking display logic, fix async new tasks - #19
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR improves the thinking display logic and fixes async task creation for agents. The changes ensure "Thinking..." appears correctly based on task state and implements proper async agent communication.
- Updates thinking display logic to check for last user message without agent responses and RPC status
- Adds RPC status tracking to TaskMessagesData to manage async operations properly
- Simplifies code by removing unused stream status logic and comments
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| agentex-ui/hooks/use-task-subscription.ts | Removes unused stream status hook and adds RPC status management to task message subscription |
| agentex-ui/hooks/use-task-messages.ts | Adds rpcStatus field to TaskMessagesData and exports the type for broader use |
| agentex-ui/components/agentex/task-messages.tsx | Updates thinking display logic to use new shouldShowThinkingForLastPair function |
| agentex-ui/components/agentex/prompt-input.tsx | Removes unused agent dependency and simplifies task creation logic |
Comments suppressed due to low confidence (1)
agentex-ui/components/agentex/task-messages.tsx:1
- The exit animation property was removed but the line remains in the diff. This appears to be an incomplete removal that should be cleaned up.
import { Fragment, memo, useEffect, useMemo, useRef, useState } from 'react';
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
declan-scale
force-pushed
the
declan-scale/thinking-logic
branch
from
October 29, 2025 18:51
d48df7d to
de298cc
Compare
MichaelSun48
approved these changes
Oct 29, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
task/createalso send aevent/sendto async agentsThinking...