-
Notifications
You must be signed in to change notification settings - Fork 8
feat(chore): export alias for bc #2048
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
scripts/generateAlias.ts
Outdated
continue | ||
} | ||
// eslint-disable-next-line no-continue | ||
if (versions.length === 0) continue |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
not usefull ?
scripts/generateAlias.ts
Outdated
} catch { | ||
console.warn(`⚠️ Pas de dossier 'src' pour ${service}, ignoré.`) | ||
// eslint-disable-next-line no-continue | ||
continue |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i think we should throw an error instead
We can remove the replace the old script to generate index.gen.ts directly finally @jremy42 |
Also check if everyting is mapped from this file packages/clients/src/api/index.ts i can already see what we had for iam for exemple: /**
* @deprecated use Iam namespace
*/
export * as IAM from './iam/index.gen' and what we have now: export { Iamv1alpha1 }
export const Iam = {
v1alpha1: Iamv1alpha1,
} |
586162f
to
b7e1c00
Compare
d70d952
to
22e5db0
Compare
BREAKING CHANGE: VPC, VPCGW, TransactionalEmail, ServerlessSQLDB, RDB, MNQ, LB, IPAM, IAM, FlexibleIP, BareMetal, AppleSilicon Signed-off-by: protobuf-ci-cd <[email protected]>
22e5db0
to
b1733aa
Compare
No description provided.