Skip to content

feat(chore): export alias for bc #2048

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Apr 24, 2025
Merged

feat(chore): export alias for bc #2048

merged 4 commits into from
Apr 24, 2025

Conversation

jremy42
Copy link
Contributor

@jremy42 jremy42 commented Apr 22, 2025

No description provided.

@jremy42 jremy42 requested a review from remyleone as a code owner April 22, 2025 15:24
Copy link

changeset-bot bot commented Apr 22, 2025

⚠️ No Changeset found

Latest commit: b1733aa

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

continue
}
// eslint-disable-next-line no-continue
if (versions.length === 0) continue
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not usefull ?

} catch {
console.warn(`⚠️ Pas de dossier 'src' pour ${service}, ignoré.`)
// eslint-disable-next-line no-continue
continue
Copy link
Contributor

@philibea philibea Apr 23, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i think we should throw an error instead

@philibea
Copy link
Contributor

We can remove the replace the old script to generate index.gen.ts directly finally @jremy42

@philibea
Copy link
Contributor

Also check if everyting is mapped from this file packages/clients/src/api/index.ts

i can already see what we had for iam for exemple:

/**
 * @deprecated use Iam namespace
 */
export * as IAM from './iam/index.gen'

and what we have now:

export { Iamv1alpha1 }
export const Iam = {
  v1alpha1: Iamv1alpha1,
}

@philibea philibea force-pushed the fix/alias_for_packages branch from 586162f to b7e1c00 Compare April 24, 2025 09:02
@philibea philibea requested review from a team as code owners April 24, 2025 09:02
@github-actions github-actions bot added tem Transactional Email issues, bugs and feature requests billing Billing issues, bugs and feature requests account Account issues, bugs and feature requests secret Managed Secret Manager issues, bugs and feature requests domain Domains issues, bugs and feature requests redis Managed Redis issues, bugs and feature requests k8s Kubernetes Kapsule issues, bugs and feature requests function Serverless function issues, bugs and feature requests instance Instance issues, bugs and feature requests registry Managed Container Registry issues, bugs and feature requests labels Apr 24, 2025
@github-actions github-actions bot added mnq Messaging and queuing issues, bugs and feature requests iot IoT issues, bugs and feature requests vpc Virtual Private Cloud (VPC) issues, bugs and feature requests webhosting Webhosting issues, bugs and feature requests iam IAM issues, bugs and feature requests flexible-ip Flexible IP issues, bugs and feature requests apple-silicon Apple Silicon issues, bugs and feature requests load-balancer Load-balancer issues, bugs and feature requests rdb Managed MySQL and PostgreSQL issues, bugs and feature requests container Container issues, bugs and feature requests baremetal vpcgw labels Apr 24, 2025
@philibea philibea force-pushed the fix/alias_for_packages branch 3 times, most recently from d70d952 to 22e5db0 Compare April 24, 2025 12:07
BREAKING CHANGE: VPC, VPCGW, TransactionalEmail, ServerlessSQLDB, RDB, MNQ, LB, IPAM, IAM, FlexibleIP, BareMetal, AppleSilicon

Signed-off-by: protobuf-ci-cd <[email protected]>
@philibea philibea force-pushed the fix/alias_for_packages branch from 22e5db0 to b1733aa Compare April 24, 2025 12:14
@philibea philibea enabled auto-merge April 24, 2025 12:18
@philibea philibea disabled auto-merge April 24, 2025 12:32
@philibea philibea added this pull request to the merge queue Apr 24, 2025
Merged via the queue into main with commit a627c5e Apr 24, 2025
8 checks passed
@philibea philibea deleted the fix/alias_for_packages branch April 24, 2025 12:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
account Account issues, bugs and feature requests apple-silicon Apple Silicon issues, bugs and feature requests baremetal billing Billing issues, bugs and feature requests container Container issues, bugs and feature requests domain Domains issues, bugs and feature requests flexible-ip Flexible IP issues, bugs and feature requests function Serverless function issues, bugs and feature requests iam IAM issues, bugs and feature requests instance Instance issues, bugs and feature requests iot IoT issues, bugs and feature requests k8s Kubernetes Kapsule issues, bugs and feature requests load-balancer Load-balancer issues, bugs and feature requests mnq Messaging and queuing issues, bugs and feature requests rdb Managed MySQL and PostgreSQL issues, bugs and feature requests redis Managed Redis issues, bugs and feature requests registry Managed Container Registry issues, bugs and feature requests secret Managed Secret Manager issues, bugs and feature requests tem Transactional Email issues, bugs and feature requests vpc Virtual Private Cloud (VPC) issues, bugs and feature requests vpcgw webhosting Webhosting issues, bugs and feature requests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants