Skip to content

feat(containers): support build args#318

Open
cyclimse wants to merge 1 commit intomasterfrom
feat/build-args
Open

feat(containers): support build args#318
cyclimse wants to merge 1 commit intomasterfrom
feat/build-args

Conversation

@cyclimse
Copy link
Contributor

Summary

What's changed?

Why do we need this?

  • It's indeed not ideal to not provide

How have you tested it?

  • Tested manually ✅

Checklist

  • I have reviewed this myself
  • There is a unit test covering every change in this PR
  • I have updated the relevant documentation

Details

Closes #317

}

const pushStream = await image.push(auth);
const pushStream = await image.push({ authconfig: auth });
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For reviewers, I have no idea how we never ran into it before, but this currently is not functional.

auth is sent to PushOptions as is, with a username/password field. This obviously is not recognized as valid options, so the auth here is not used for pushing.

This is especially annoying because we do a checkAuth initially but it ends up being useless as those credentials are not used for pushing

Instead, the local docker credentials in ~HOME/. docker/config.json are used. I ran into this because my local credentials were invalid and I couldn't understand why somehow checkAuth was working but my push was silently failing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add support for buildArgs option when building container images with the directory option

2 participants

Comments