Open
Conversation
cyclimse
commented
Feb 19, 2026
| } | ||
|
|
||
| const pushStream = await image.push(auth); | ||
| const pushStream = await image.push({ authconfig: auth }); |
Contributor
Author
There was a problem hiding this comment.
For reviewers, I have no idea how we never ran into it before, but this currently is not functional.
auth is sent to PushOptions as is, with a username/password field. This obviously is not recognized as valid options, so the auth here is not used for pushing.
This is especially annoying because we do a checkAuth initially but it ends up being useless as those credentials are not used for pushing
Instead, the local docker credentials in ~HOME/. docker/config.json are used. I ran into this because my local credentials were invalid and I couldn't understand why somehow checkAuth was working but my push was silently failing.
thomas-tacquet
approved these changes
Feb 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
What's changed?
buildArgsas proposed in Add support for buildArgs option when building container images with the directory option #317Why do we need this?
How have you tested it?
Checklist
Details
Closes #317