feat: support letsencrypt_enabled on canonical domain#19
Open
josephpage wants to merge 1 commit intomainfrom
Open
feat: support letsencrypt_enabled on canonical domain#19josephpage wants to merge 1 commit intomainfrom
josephpage wants to merge 1 commit intomainfrom
Conversation
josephpage
force-pushed
the
feat/letsencrypt
branch
from
36ea008 to
9837917
Compare
Add letsencrypt variable (default: true) to control automatic Let's Encrypt TLS certificate provisioning on the canonical domain. Set to false when using a custom certificate (e.g. wildcard). Replaces the outdated comment about unsupported TLS attributes in domains.tf. Requires scalingo provider ~> 2.7 (letsencrypt_enabled added in v2.3.0).
josephpage
force-pushed
the
feat/letsencrypt
branch
from
9837917 to
e919bc1
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Test plan