Skip to content

refactor env parameters#2394

Draft
SylvainSenechal wants to merge 15 commits intodevelopment/2.14from
improvement/ZENKO-5259
Draft

refactor env parameters#2394
SylvainSenechal wants to merge 15 commits intodevelopment/2.14from
improvement/ZENKO-5259

Conversation

@SylvainSenechal
Copy link
Copy Markdown
Contributor

Issue: ZENKO-5259

wip

@bert-e
Copy link
Copy Markdown
Contributor

bert-e commented Apr 24, 2026

Hello sylvainsenechal,

My role is to assist you with the merge of this
pull request. Please type @bert-e help to get information
on this process, or consult the user documentation.

Available options
name description privileged authored
/after_pull_request Wait for the given pull request id to be merged before continuing with the current one.
/bypass_author_approval Bypass the pull request author's approval
/bypass_build_status Bypass the build and test status
/bypass_commit_size Bypass the check on the size of the changeset TBA
/bypass_incompatible_branch Bypass the check on the source branch prefix
/bypass_jira_check Bypass the Jira issue check
/bypass_peer_approval Bypass the pull request peers' approval
/bypass_leader_approval Bypass the pull request leaders' approval
/approve Instruct Bert-E that the author has approved the pull request. ✍️
/create_pull_requests Allow the creation of integration pull requests.
/create_integration_branches Allow the creation of integration branches.
/no_octopus Prevent Wall-E from doing any octopus merge and use multiple consecutive merge instead
/unanimity Change review acceptance criteria from one reviewer at least to all reviewers
/wait Instruct Bert-E not to run until further notice.
Available commands
name description privileged
/help Print Bert-E's manual in the pull request.
/status Print Bert-E's current status in the pull request TBA
/clear Remove all comments from Bert-E from the history TBA
/retry Re-start a fresh build TBA
/build Re-start a fresh build TBA
/force_reset Delete integration branches & pull requests, and restart merge process from the beginning.
/reset Try to remove integration branches unless there are commits on them which do not appear on the source branch.

Status report is not available.

@bert-e
Copy link
Copy Markdown
Contributor

bert-e commented Apr 24, 2026

Incorrect fix version

The Fix Version/s in issue ZENKO-5259 contains:

  • None

Considering where you are trying to merge, I ignored possible hotfix versions and I expected to find:

  • 2.14.4

Please check the Fix Version/s of ZENKO-5259, or the target
branch of this pull request.

@SylvainSenechal SylvainSenechal force-pushed the improvement/ZENKO-5259 branch from b80c535 to 0ddc9e7 Compare April 27, 2026 16:30
// Some hooks are defined in cli-testing and use the configuration,
// we need to have this run before anything else
Zenko.testsConfig = await populateParameters();
console.log("before all ", Zenko.testsConfig);
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Security: console.log dumps the entire testsConfig object, which includes AdminCredentials, ServiceUsers, ZenkoAccount.credentials (access keys, secret keys, session tokens). This will print secrets to CI logs.

Suggested change
console.log("before all ", Zenko.testsConfig);

console.log("before all ", Zenko.testsConfig);
});

// import 'cli-testing/hooks/KeycloakSetup';
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Commented-out import left behind. Remove it or re-enable it — commented-out code in a refactoring PR adds confusion about intent.

Suggested change
// import 'cli-testing/hooks/KeycloakSetup';

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants