refactor env parameters#2394
Conversation
Hello sylvainsenechal,My role is to assist you with the merge of this Available options
Available commands
Status report is not available. |
Incorrect fix versionThe
Considering where you are trying to merge, I ignored possible hotfix versions and I expected to find:
Please check the |
Issue: ZENKO-5251
b80c535 to
0ddc9e7
Compare
| // Some hooks are defined in cli-testing and use the configuration, | ||
| // we need to have this run before anything else | ||
| Zenko.testsConfig = await populateParameters(); | ||
| console.log("before all ", Zenko.testsConfig); |
There was a problem hiding this comment.
Security: console.log dumps the entire testsConfig object, which includes AdminCredentials, ServiceUsers, ZenkoAccount.credentials (access keys, secret keys, session tokens). This will print secrets to CI logs.
| console.log("before all ", Zenko.testsConfig); |
| console.log("before all ", Zenko.testsConfig); | ||
| }); | ||
|
|
||
| // import 'cli-testing/hooks/KeycloakSetup'; |
There was a problem hiding this comment.
Commented-out import left behind. Remove it or re-enable it — commented-out code in a refactoring PR adds confusion about intent.
| // import 'cli-testing/hooks/KeycloakSetup'; |
Issue: ZENKO-5259
wip