Open
Conversation
tcarmet
requested changes
Jul 27, 2023
Contributor
tcarmet
left a comment
tcarmet
left a comment
There was a problem hiding this comment.
- Add a test workflow that calls this action
|
|
||
|
|
||
| runs: | ||
| using: "composite" |
Contributor
There was a problem hiding this comment.
Instead of making it a composite action, make it a docker one. Removing the need to ask users to use the proper container image and giving you more control over the environment.
Comment on lines
+7
to
+9
| on: | ||
| workflow_dispatch: | ||
| ```yaml |
Contributor
There was a problem hiding this comment.
Suggested change
| on: | |
| workflow_dispatch: | |
| ```yaml | |
| ```yaml | |
| on: | |
| workflow_dispatch: | |
| # optionally show example with inputs. | |
| inputs: | |
| SOURCE_REPO: | |
| required: true | |
| IMAGE_NAME: | |
| required: true | |
Then use those vars below.
Comment on lines
+21
to
+22
| SRC_USERNAME: ${{ secrets.<src-username> }} | ||
| SRC_PASSWORD: ${{ secrets.<src-password> }} |
Contributor
There was a problem hiding this comment.
Suggested change
| SRC_USERNAME: ${{ secrets.<src-username> }} | |
| SRC_PASSWORD: ${{ secrets.<src-password> }} | |
| SRC_USERNAME: ${{ secrets.REGISTRY_LOGIN }} | |
| SRC_PASSWORD: ${{ secrets.REGISTRY_PASSWORD }} |
| uses: scality/actions/registry-image-sync | ||
| with: | ||
| SOURCE_REPO: <repo-name> # Ex bert-e | ||
| IMAGE_NAME: <image-name> # Ex bert-e |
Contributor
There was a problem hiding this comment.
You're making some parameters as required but not mentioning them here, feel free to setup default values for the destination.
| required: true | ||
| TARGET_REGISTRY: | ||
| description: "the target registry" | ||
| required: true |
Contributor
There was a problem hiding this comment.
Suggested change
| required: true | |
| required: false | |
| default: ghcr.io/scality |
| SRC_PASSWORD: | ||
| description: "the password in source registry" | ||
| DEST_USERNAME: | ||
| description: "the username in destination registry" |
Contributor
There was a problem hiding this comment.
Suggested change
| description: "the username in destination registry" | |
| description: "the username in destination registry" | |
| default: ${{ github.actor }} |
| DEST_USERNAME: | ||
| description: "the username in destination registry" | ||
| DEST_PASSWORD: | ||
| description: "the password in destination registry" |
Contributor
There was a problem hiding this comment.
Suggested change
| description: "the password in destination registry" | |
| description: "the password in destination registry" | |
| default: ${{ github.token }} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.