Improvement/cldsrv 724-backbeat-related-functional-tests #5985

benzekrimaha · 2025-10-23T16:14:03Z

Please note that this PR also takles the rest of the unmigrated code , better to review it by commit to have the context

Issue: CLDSRV-724

codecov · 2025-11-05T08:18:31Z

Codecov Report

❌ Patch coverage is 33.33333% with 6 lines in your changes missing coverage. Please review.
✅ Project coverage is 84.35%. Comparing base (0fec989) to head (df480a2).
✅ All tests successful. No failed tests found.

Files with missing lines	Patch %	Lines
lib/routes/routeBackbeat.js	33.33%	6 Missing ⚠️

Additional details and impacted files

Files with missing lines	Coverage Δ
lib/routes/routeBackbeat.js	`75.79% <33.33%> (+2.40%)`	⬆️

... and 28 files with indirect coverage changes

@@                                       Coverage Diff                                       @@
##           improvement/CLDSRV-724-service-get-related-functional-tests    #5985      +/-   ##
===============================================================================================
+ Coverage                                                        81.00%   84.35%   +3.34%     
===============================================================================================
  Files                                                              204      204              
  Lines                                                            12890    12899       +9     
===============================================================================================
+ Hits                                                             10442    10881     +439     
+ Misses                                                            2448     2018     -430

Flag	Coverage Δ
file-ft-tests	`67.55% <0.00%> (+7.42%)`	⬆️
kmip-ft-tests	`28.11% <0.00%> (+<0.01%)`	⬆️
mongo-v0-ft-tests	`68.78% <0.00%> (+7.30%)`	⬆️
mongo-v1-ft-tests	`68.88% <0.00%> (+7.42%)`	⬆️
multiple-backend	`35.23% <0.00%> (-0.03%)`	⬇️
sur-tests	`36.35% <0.00%> (+0.78%)`	⬆️
sur-tests-inflights	`37.39% <0.00%> (-0.03%)`	⬇️
unit	`69.90% <33.33%> (-0.03%)`	⬇️
utapi-v2-tests	`34.22% <0.00%> (-0.03%)`	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:

📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

SylvainSenechal · 2025-12-09T14:38:49Z

tests/functional/aws-node-sdk/test/multipleBackend/utils.js

+                if (attempt < MAX_VERSIONING_CHECKS) {
+                    await new Promise(resolve => setTimeout(resolve, VERSIONING_CHECK_INTERVAL));
+                } else {
+                    if (callback) {


if we've reached max attempt, and get bucket versioning doesnt't fail but also doesn't return status enabled, should'nt this return an error ?

tests/functional/aws-node-sdk/test/multipleBackend/utils.js

SylvainSenechal · 2025-12-09T14:54:06Z

tests/functional/raw-node/test/GCP/bucket/get.js

        it('should return 404 and NoSuchBucket', done => {
            const badBucketName = `nonexistingbucket-${genUniqID()}`;
-            gcpClient.getBucket({
+            gcpClient.listObjects({


Why changing from getBucket to listObject ? I guess the test is still valid because listObject will also return noSuchBucket but still, here we want to test the getBucket api I think

SylvainSenechal · 2025-12-09T15:26:34Z

tests/functional/sse-kms-migration/load.js

 * round robin is confined to each nodejs cluster processes
 */
-const APPROX = Math.floor(0.1 * TOTAL_OBJECTS_PER_NODE);
+const APPROX = Math.ceil(0.2 * TOTAL_OBJECTS_PER_NODE);


do you remember what happened here that you need to do this change ?

The old Math.floor(0.1 * TOTAL_OBJECTS_PER_NODE) let counts drift only ~10% low/high; on the ci we were still failing because a cluster process often handles more than 10%. Switching to Math.ceil(0.2 * TOTAL_OBJECTS_PER_NODE) widens that window to ±20% (and guarantees at least one packet of slack), so we stop treating normal round‑robin skew as a test failure.

SylvainSenechal

bigbig pr again. this time I left a bit more comments but actually not many changes requested, its mostly questions to double check the changes, and make sure we understand why the changes are done because I found 2/3 things were curious

DarkIsDude

Congrats again. Sylvain did a good review, not a lot to add more

DarkIsDude · 2025-12-12T16:14:13Z

.github/workflows/tests.yaml

-        password: ${{ secrets.ARTIFACTS_PASSWORD }}
-        source: /tmp/artifacts
-      if: always()
+  # ceph-backend-test:


Just delete them ? We have githistory if needed

DarkIsDude · 2025-12-12T16:22:20Z

lib/data/wrapper.js

    client = new DataFileInterface(config);
    implName = 'file';
 } else if (config.backends.data === 'multiple') {
+    Object.keys(config.locationConstraints).filter(k => 


Agree too, it's weird ?

DarkIsDude · 2025-12-12T16:31:18Z

tests/functional/aws-node-sdk/test/bucket/getLocation.js

-                const expectedLocation = data.LocationConstraint || '';
-                assert.deepStrictEqual(expectedLocation, '');
+                // SDK v3 returns undefined for us-east-1, normalize to empty string for comparison
+                const locationConstraint = data.LocationConstraint || '';


Then if I get it right we can check that the value is undefined directly ?

DarkIsDude · 2025-12-12T16:36:14Z

tests/functional/aws-node-sdk/test/mdSearch/utils/helpers.js

+                    done();
                }
+            } else if (testResult && typeof testResult === 'object' && testResult.code) {
+                // This was expected to be an error, but we got success


Suggested change

// This was expected to be an error, but we got success

DarkIsDude · 2025-12-12T16:38:00Z

tests/functional/aws-node-sdk/test/multipleBackend/acl/aclAwsVersioning.js

+        })
+        .then(data => {
+            // eslint-disable-next-line no-unused-vars
+            const {$metadata, ...aclData} = data;


Why this eslint ? Is really not used ? a good practice is to do add a why at the end of a lint disable instruction

$metadata won't be used , that's why

DarkIsDude · 2025-12-12T16:39:27Z

tests/functional/aws-node-sdk/test/multipleBackend/delete/deleteAwsVersioning.js

        'backend successfully', done => {
            const key = `somekey-${genUniqID()}`;
            async.waterfall([
+                next => waitForVersioningBeforePut(s3, bucket, err => {


Same here and following iteration

DarkIsDude · 2025-12-12T17:11:03Z

tests/functional/aws-node-sdk/test/multipleBackend/objectPutCopyPart/objectPutCopyPartAzure.js

+                    next => {
+                            s3.send(new AbortMultipartUploadCommand(paramsAzure))
+                                    .then(() => next())
+                                    .catch(next);
+                    },


Suggested change

next => {

s3.send(new AbortMultipartUploadCommand(paramsAzure))

.then(() => next())

.catch(next);

},

async() => s3.send(new AbortMultipartUploadCommand(paramsAzure)),

we can do that ?

DarkIsDude · 2025-12-12T17:22:13Z

tests/functional/aws-node-sdk/test/multipleBackend/put/putGcp.js

+            })
+            .catch(err => {
+                if (err && err.name === 'NetworkingError') {
+                    setTimeout(() => {


We don't have a limit on the retry ?

DarkIsDude · 2025-12-12T17:32:17Z

tests/functional/backbeat/excludedDataStoreName.js

        });
    });
 });
+


Suggested change

DarkIsDude · 2025-12-12T17:34:36Z

tests/functional/backbeat/listLifecycleCurrents.js

+            }))
+                .then(() => next())
+                .catch(next),
+            next => s3.send(new DeleteObjectCommand({ Bucket: testBucket, Key: keyName1 }))


Here too (and it's not the only one)

Suggested change

next => s3.send(new DeleteObjectCommand({ Bucket: testBucket, Key: keyName1 }))

async () => s3.send(new DeleteObjectCommand({ Bucket: testBucket, Key: keyName1 })),

I'd rather keep the next here it's part of a chain

benzekrimaha force-pushed the improvement/CLDSRV-724-service-get-related-functional-tests branch 3 times, most recently from 72dd6ed to cd35cca Compare October 28, 2025 15:59

benzekrimaha force-pushed the improvement/CLDSRV-724-backbeat-related-functional-tests branch 2 times, most recently from 425731c to 2b9959d Compare October 28, 2025 16:03

scality deleted a comment from codecov bot Nov 5, 2025

benzekrimaha force-pushed the improvement/CLDSRV-724-backbeat-related-functional-tests branch 5 times, most recently from 8c9eb10 to 3ab4eae Compare November 13, 2025 10:44

benzekrimaha force-pushed the improvement/CLDSRV-724-backbeat-related-functional-tests branch 2 times, most recently from 17d2fcb to 198582c Compare November 20, 2025 17:19

benzekrimaha force-pushed the improvement/CLDSRV-724-backbeat-related-functional-tests branch 3 times, most recently from 2c806e4 to 836c556 Compare November 28, 2025 15:18

benzekrimaha force-pushed the improvement/CLDSRV-724-backbeat-related-functional-tests branch 2 times, most recently from 26ce909 to 8383cf9 Compare December 2, 2025 17:24

benzekrimaha force-pushed the improvement/CLDSRV-724-service-get-related-functional-tests branch from cd35cca to 0fec989 Compare December 4, 2025 06:39

benzekrimaha changed the title ~~Improvement/cldsrv 724 backbeat related functional tests~~ Improvement/cldsrv 724-backbeat-related-functional-tests Dec 4, 2025

benzekrimaha added 9 commits December 4, 2025 12:35

backbeat functional tests migration

a1fff68

aws-node-sdk bucket functional tests migration

91fe932

aws-node-sdk multiple backend tests migration

7408990

raw-node gcp object and bucket tests migration

0ff38c1

routBackbeat migration adaptation

1c371b1

aws-node-sdk test utils migration

03dc295

raw-node rest of code migration

ac83417

rest of code migration

b07e438

deps install

c2f4c3a

SylvainSenechal reviewed Dec 9, 2025

View reviewed changes

tests/functional/aws-node-sdk/test/multipleBackend/utils.js Show resolved Hide resolved

SylvainSenechal reviewed Dec 9, 2025

View reviewed changes

SylvainSenechal requested changes Dec 9, 2025

View reviewed changes

fixups post reviews

5313153

benzekrimaha requested review from a team, SylvainSenechal and delthas December 11, 2025 18:40

DarkIsDude approved these changes Dec 12, 2025

View reviewed changes

DarkIsDude requested changes Dec 12, 2025

View reviewed changes

benzekrimaha added 3 commits December 18, 2025 14:12

bump arsenal with latest fixups

eee9699

bump arsenal with latest fixups

1d9770c

bump arsenal with latest fixups

7e3a81d

benzekrimaha force-pushed the improvement/CLDSRV-724-backbeat-related-functional-tests branch from 3a0af19 to 7e3a81d Compare December 18, 2025 16:30

benzekrimaha added 3 commits December 18, 2025 18:17

bump arsenal with latest fixups

4f3c944

bump arsenal with latest fixups

f9fbace

bump arsenal with latest fixups

ce181cb

benzekrimaha force-pushed the improvement/CLDSRV-724-backbeat-related-functional-tests branch from 94d9c72 to ce181cb Compare December 19, 2025 06:24

benzekrimaha added 10 commits December 19, 2025 07:52

bump arsenal with latest fixups

42ed39e

bump arsenal with latest fixups

908ba8d

bump arsenal with latest fixups

e30a7b0

bump arsenal with latest fixups

c73a9c1

bump arsenal with latest fixups

31d137c

fixups post reviews

80e3e93

fixups post reviews

82472d0

fixups post reviews

74d7db3

fixups post reviews

1783b09

fixups post reviews

df480a2

benzekrimaha requested a review from DarkIsDude December 22, 2025 17:22

	next => s3.send(new DeleteObjectCommand({ Bucket: testBucket, Key: keyName1 }))
	async () => s3.send(new DeleteObjectCommand({ Bucket: testBucket, Key: keyName1 })),

Improvement/cldsrv 724-backbeat-related-functional-tests #5985

Are you sure you want to change the base?

Improvement/cldsrv 724-backbeat-related-functional-tests #5985

Uh oh!

Conversation

benzekrimaha commented Oct 23, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

codecov bot commented Nov 5, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

SylvainSenechal left a comment

Choose a reason for hiding this comment

Uh oh!

DarkIsDude left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

benzekrimaha commented Oct 23, 2025 •

edited

Loading

codecov bot commented Nov 5, 2025 •

edited

Loading