-
Notifications
You must be signed in to change notification settings - Fork 253
Improvement/cldsrv 875 integrate shared prettier #6124
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
benzekrimaha
wants to merge
7
commits into
development/9.3
Choose a base branch
from
improvement/CLDSRV-875-Integrate-shared-prettier
base: development/9.3
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
b6bd810
add shared prettier baseline
benzekrimaha 8dacb04
add ci prettier changed-file check
benzekrimaha ed72659
update doc for package.json linting
benzekrimaha 568360a
format test.yaml file to meet prettier requirements
benzekrimaha 902ab8b
ignore generated files
benzekrimaha 49bb1b5
fixup! add ci prettier changed-file check
benzekrimaha 2699e18
fixup! update doc for package.json linting
benzekrimaha File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,51 @@ | ||
| --- | ||
| name: lint | ||
|
|
||
| on: | ||
| pull_request: | ||
|
|
||
| permissions: | ||
| contents: read | ||
|
|
||
| concurrency: | ||
| group: ${{ github.workflow }}-${{ github.head_ref || github.ref_name || github.sha }} | ||
| cancel-in-progress: true | ||
|
|
||
| jobs: | ||
| lint: | ||
| runs-on: ubuntu-24.04 | ||
| steps: | ||
| - name: Checkout | ||
| uses: actions/checkout@v4 | ||
| - uses: actions/setup-node@v4 | ||
| with: | ||
| node-version: '22' | ||
| cache: yarn | ||
| - name: install typescript | ||
| shell: bash | ||
| run: yarn global add typescript@4.9.5 | ||
| - name: install dependencies | ||
| run: yarn install --frozen-lockfile --network-concurrency 1 | ||
| - name: Fetch base for Prettier | ||
| env: | ||
| BASE_REF: ${{ github.event.pull_request.base.ref }} | ||
| run: git fetch --no-tags origin "$BASE_REF" --depth=50 | ||
| - name: Prettier (changed files) | ||
| run: scripts/format-changed.sh | ||
| env: | ||
| BASE_SHA: ${{ github.event.pull_request.base.sha }} | ||
| BASE_REF: ${{ github.event.pull_request.base.ref }} | ||
| - uses: actions/setup-python@v5 | ||
| with: | ||
| python-version: '3.9' | ||
| cache: pip | ||
| - name: Install python deps | ||
| run: pip install flake8 | ||
| - name: Lint Javascript | ||
| run: yarn run --silent lint -- --max-warnings 0 | ||
| - name: Lint Markdown | ||
| run: yarn run --silent lint_md | ||
| - name: Lint python | ||
| run: flake8 $(git ls-files "*.py") | ||
| - name: Lint Yaml | ||
| run: yamllint -c yamllint.yml $(git ls-files "*.yml") | ||
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.