Skip to content

improvement(CUI-14): enforce checkbox label placement pattern#1084

Merged
bert-e merged 1 commit intodevelopment/1.0from
improvement/CUI-14-checkbox-label-pattern
Apr 22, 2026
Merged

improvement(CUI-14): enforce checkbox label placement pattern#1084
bert-e merged 1 commit intodevelopment/1.0from
improvement/CUI-14-checkbox-label-pattern

Conversation

@JeanMarcMilletScality
Copy link
Copy Markdown
Contributor

@JeanMarcMilletScality JeanMarcMilletScality commented Apr 21, 2026

Summary

  • Add JSDoc to the label prop of Checkbox clarifying it should only be used for standalone checkboxes (not inside a FormGroup)

Jira: https://scality.atlassian.net/browse/CUI-14

@bert-e
Copy link
Copy Markdown
Contributor

bert-e commented Apr 21, 2026

Hello jeanmarcmilletscality,

My role is to assist you with the merge of this
pull request. Please type @bert-e help to get information
on this process, or consult the user documentation.

Available options
name description privileged authored
/after_pull_request Wait for the given pull request id to be merged before continuing with the current one.
/bypass_author_approval Bypass the pull request author's approval
/bypass_build_status Bypass the build and test status
/bypass_commit_size Bypass the check on the size of the changeset TBA
/bypass_incompatible_branch Bypass the check on the source branch prefix
/bypass_jira_check Bypass the Jira issue check
/bypass_peer_approval Bypass the pull request peers' approval
/bypass_leader_approval Bypass the pull request leaders' approval
/approve Instruct Bert-E that the author has approved the pull request. ✍️
/create_pull_requests Allow the creation of integration pull requests.
/create_integration_branches Allow the creation of integration branches.
/no_octopus Prevent Wall-E from doing any octopus merge and use multiple consecutive merge instead
/unanimity Change review acceptance criteria from one reviewer at least to all reviewers
/wait Instruct Bert-E not to run until further notice.
Available commands
name description privileged
/help Print Bert-E's manual in the pull request.
/status Print Bert-E's current status in the pull request TBA
/clear Remove all comments from Bert-E from the history TBA
/retry Re-start a fresh build TBA
/build Re-start a fresh build TBA
/force_reset Delete integration branches & pull requests, and restart merge process from the beginning.
/reset Try to remove integration branches unless there are commits on them which do not appear on the source branch.

Status report is not available.

@bert-e
Copy link
Copy Markdown
Contributor

bert-e commented Apr 21, 2026

Waiting for approval

The following approvals are needed before I can proceed with the merge:

  • the author

  • one peer

Peer approvals must include at least 1 approval from the following list:

@bert-e
Copy link
Copy Markdown
Contributor

bert-e commented Apr 22, 2026

Conflict

There is a conflict between your branch improvement/CUI-14-checkbox-label-pattern and the
destination branch development/1.0.

Please resolve the conflict on the feature branch (improvement/CUI-14-checkbox-label-pattern).

git fetch && \
git checkout origin/improvement/CUI-14-checkbox-label-pattern && \
git merge origin/development/1.0

Resolve merge conflicts and commit

git push origin HEAD:improvement/CUI-14-checkbox-label-pattern

…mponent

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
@JeanMarcMilletScality JeanMarcMilletScality force-pushed the improvement/CUI-14-checkbox-label-pattern branch from b798f4a to 2520a84 Compare April 22, 2026 09:23
@bert-e
Copy link
Copy Markdown
Contributor

bert-e commented Apr 22, 2026

Waiting for approval

The following approvals are needed before I can proceed with the merge:

  • the author

  • one peer

Peer approvals must include at least 1 approval from the following list:

@bert-e
Copy link
Copy Markdown
Contributor

bert-e commented Apr 22, 2026

Waiting for approval

The following approvals are needed before I can proceed with the merge:

  • the author

  • one peer

Peer approvals must include at least 1 approval from the following list:

@JeanMarcMilletScality
Copy link
Copy Markdown
Contributor Author

/approve

@bert-e
Copy link
Copy Markdown
Contributor

bert-e commented Apr 22, 2026

I have successfully merged the changeset of this pull request
into targetted development branches:

  • ✔️ development/1.0

Please check the status of the associated issue CUI-14.

Goodbye jeanmarcmilletscality.

The following options are set: approve

@bert-e bert-e merged commit 2520a84 into development/1.0 Apr 22, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants