MK8S-79 - Mount RAID management vendor tools from host machines#14
Merged
MK8S-79 - Mount RAID management vendor tools from host machines#14
MK8S-79 - Mount RAID management vendor tools from host machines#14Conversation
Signed-off-by: Valentin Daviot <valentin.daviot@scality.com>
vdaviot
changed the title
MK8S-79 - Mount hardware toolsMK8S-79 - Mount RAID management vendor tools from host machines
Signed-off-by: Valentin Daviot <valentin.daviot@scality.com>
vdaviot
force-pushed
the
improvement/MK8s-79-mount-hardware-tools
branch
from
81fb619 to
f5f196d
Compare
Signed-off-by: Valentin Daviot <valentin.daviot@scality.com>
ezekiel-alexrod
approved these changes
Apr 1, 2026
TeddyAndrieux
approved these changes
Apr 1, 2026
TeddyAndrieux
left a comment
TeddyAndrieux
left a comment
There was a problem hiding this comment.
Just a minor comment LGTM
(We may consider in the future to run as non root, but let's not do it for now)
Comment on lines
+60
to
+66
| func getEnvOrDefault(key, defaultValue string) string { | ||
| if value := os.Getenv(key); value != "" { | ||
| return value | ||
| } | ||
|
|
||
| return defaultValue | ||
| } |
There was a problem hiding this comment.
Any reason to not use your usual lib to load env variable in a config struct ?
Collaborator
Author
There was a problem hiding this comment.
Its done in another branch, just wanted to iterate fast on this one 👍
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.