(KC24) Use Dedicated SQL Session for Truststore#21
Merged
JBWatenbergScality merged 7 commits intohotfix-1.4.2-24.0.3from Feb 25, 2026
Merged
Conversation
…toreProvider to handle connection closed errors
JBWatenbergScality
changed the title
…rors by setting flush mode to COMMIT during query execution. This prevents issues related to pending changes during cascade operations and improves retry logic for connection and flush errors.
getCertificates() and getCertificates(boolean) now always execute in a fresh Keycloak session via KeycloakModelUtils.runJobInTransaction(), obtaining a new JDBC connection from the pool. This replaces the previous approach of em.clear() (which did not reset the connection), manual retry loops, flush mode manipulation, and in-memory cache fallback — none of which reliably handled the cold-start case where the current session's connection is closed. Verified 1000/1000 under concurrent load (10 workers, no delay). Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
JBWatenbergScality
changed the title
JBWatenbergScality
changed the title
JBWatenbergScality
deleted the
bugfix/backport-add-retry-logic-on-connection-closed
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context:
JDBC Connection gets closed under load after some time.
What Changed:
Replace retry/cache complexity with executeInNewSession for reads
getCertificates() and getCertificates(boolean) now always execute in a
fresh Keycloak session via KeycloakModelUtils.runJobInTransaction(),
obtaining a new JDBC connection from the pool. This replaces the
previous approach of em.clear() (which did not reset the connection),
manual retry loops, flush mode manipulation, and in-memory cache
fallback — none of which reliably handled the cold-start case where the
current session's connection is closed.
How was it validated
Verified 1000/1000 under concurrent load (10 workers, no delay).