Fix Galois field operations and add reference counting for table init…#6
Merged
benoit-a merged 1 commit intodevelopment/1.0from Dec 18, 2025
Merged
Conversation
…ialization
This commit addresses two important improvements to the RS Vandermonde
implementation:
1. Type safety fix in region_multiply():
- Cast from_buf[i] to unsigned char before passing to rs_galois_mult()
- Ensures correct behavior when processing signed char values in
Galois field arithmetic operations
- Applied to both XOR and non-XOR code paths
2. Reference counting for Galois table initialization:
- Add init_counter to track multiple initialization/deinitialization
calls
- Prevent double initialization of log_table and ilog_table
- Implement proper reference counting in rs_galois_deinit_tables()
to only free tables when all references are released
- Set pointers to NULL after freeing to prevent use-after-free issues
These changes improve robustness and prevent potential crashes from
improper table lifecycle management.
benoit-a
approved these changes
Dec 18, 2025
Author
|
/approve |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…ialization
This commit addresses two important improvements to the RS Vandermonde implementation:
Type safety fix in region_multiply():
Reference counting for Galois table initialization:
These changes improve robustness and prevent potential crashes from improper table lifecycle management.