LOGC-54: Add e2e test for TLS cipher suite and protocol in access logs#136
Open
LOGC-54: Add e2e test for TLS cipher suite and protocol in access logs#136
Conversation
When cloudserver runs behind nginx (TLS termination), the cipher suite and TLS version are forwarded via X-SSL-Cipher and X-SSL-Protocol headers. Add an e2e test verifying these fields appear correctly in the server access logs.
|
LGTM Review by Claude Code |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds an end-to-end test verifying that TLS cipher suite and protocol version are correctly captured in S3 Server Access Log records when requests go through the nginx with TLS termination.
This validates the fix from scality/cloudserver#6091
Nginx support added in workbench in scality/workbench#73