Skip to content

Commit 9b78672

Browse files
ChengYanJing-carre
andauthored
Update .claude/skills/review-pr/SKILL.md
Co-authored-by: Guillaume CARRE <122804551+g-carre@users.noreply.github.com>
1 parent dd441f8 commit 9b78672

File tree

1 file changed

+3
-1
lines changed

1 file changed

+3
-1
lines changed

.claude/skills/review-pr/SKILL.md

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -52,7 +52,9 @@ gh pr diff <number> --repo <owner/repo>
5252
| Python / buildchain | Correct doit task dependencies and file targets; proper pytest fixtures; behave step definitions match feature files; no hardcoded paths (use constants.py) |
5353
| Security | No secrets/tokens in plain text; no OWASP-relevant issues (injection, XSS, insecure defaults) |
5454
| Breaking changes | Public API changes, CRD schema changes, Salt pillar schema changes, UI prop interface changes |
55-
55+
| Test coverage | New logic paths have corresponding unit tests; changed functions have updated tests; no test files deleted without replacement, no orphan test that would be never run |
56+
| Test impact | Changes to shared code (`map.jinja`, `constants.py`, CRD types, API types) are reflected in dependent tests across all affected layers |
57+
| BDD / integration | New user-facing behavior has matching behave scenarios in `tests/`; modified Salt orchestrations have updated integration steps |
5658
4. **Deliver your review:**
5759

5860
### If CI mode: post to GitHub

0 commit comments

Comments
 (0)