Skip to content

Commit dd441f8

Browse files
ChengYanJing-carre
andauthored
Update .claude/skills/review-pr/SKILL.md
Co-authored-by: Guillaume CARRE <122804551+g-carre@users.noreply.github.com>
1 parent d16418f commit dd441f8

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

.claude/skills/review-pr/SKILL.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -46,7 +46,7 @@ gh pr diff <number> --repo <owner/repo>
4646
| TypeScript/React | Prop changes (missing/wrong types), missing `key` props in lists, proper hook usage, no `console.log` in production code |
4747
| Scality dep pinning | `@scality/core-ui`, `@scality/module-federation` must be pinned to a specific tag/commit, not a branch |
4848
| External dep pinning | `@kubernetes/client-node` must be pinned to a specific git tag in package.json |
49-
| Salt states | Correct use of requisites (`require`, `watch`, `onchanges`); no hardcoded credentials; proper Jinja templating |
49+
| Salt states | Correct use of requisites (`require`, `watch`, `onchanges`); no hardcoded credentials; proper Jinja templating; proper map.jinja templating; ochestartions states ordering |
5050
| Helm/Kustomize | Resource limits set, security contexts defined, proper label selectors, upgrade path preserved |
5151
| Python | No bare `except:`; specific exception types; type hints on new functions; no blocking calls in async context |
5252
| Python / buildchain | Correct doit task dependencies and file targets; proper pytest fixtures; behave step definitions match feature files; no hardcoded paths (use constants.py) |

0 commit comments

Comments
 (0)